[PATCH] D133340: [PowerPC][GISel]select floating point constant from TOC

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:644
+  // TODO: handle 32-bit.
+  // TODO: Enabling floating point constant selection on AIX requires global
+  // isel on big endian target enabled first.
----------------
nit: constant pool


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:681
+
+    if (CModel == CodeModel::Large) {
+      // For large code model, generate LDtocL(CPI, ADDIStocHA8(X2, CPI))
----------------
nit: We can omit the `{ }` since we have one assignment inside.


================
Comment at: llvm/test/MachineVerifier/test_g_constant_pool.mir:1
+#RUN: not --crash llc -o - -march=arm64 -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: aarch64-registered-target
----------------
Nit: Spacing before `RUN` and this line may be too long.


================
Comment at: llvm/test/MachineVerifier/test_g_constant_pool.mir:2
+#RUN: not --crash llc -o - -march=arm64 -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: aarch64-registered-target
+
----------------
A question I had was, do we need a PPC version of this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133340/new/

https://reviews.llvm.org/D133340