[PATCH] D142047: [opt] Fix static code analysis concerns

[Arvind Sudarsanam via Phabricator via llvm-commits]

asudarsa added a comment.

In D142047#4066364 <https://reviews.llvm.org/D142047#4066364>, @aeubanks wrote:

> lgtm
>
> do you need me to push this for you?

Yes please. That will be great.

Thanks again



================
Comment at: llvm/tools/opt/NewPMDriver.cpp:370
       if (!P)
         errs() << "CSInstrUse needs to be together with InstrUse";
+      else
----------------
aeubanks wrote:
> asudarsa wrote:
> > aeubanks wrote:
> > > we should instead `return false` anywhere we're printing an error message
> > Thanks for the review. I have addressed it.
> sorry, could you also update the two places above that print an error message?
That's a good catch. Thanks @aeubanks. I have updated them as well. I verified that there are no other sites in this module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142047/new/

https://reviews.llvm.org/D142047