[PATCH] D141865: [llvm][GenericUniformity] Hack around strict is_invocable() checks

Krzysztof Drewniak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 10:19:20 PST 2023


krzysz00 added a comment.

The second version of the diff, which was one that made the build error (with what I'd consider a supported set of compilers) go away, caused linker errors in the pre-merge checks because the `ImplDeleter` template wasn't instantiated. Adding instantiations caused the build error to return, and the fix for that was to move the deleter out of the `GenericUniformityInfo` into its own struct.

I think part of the trouble here was that `GenericUniformityInfo<>` is an incomplete type at the points where the `reset()` call is being instantiated, and so the `is_invocable` fails.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141865/new/

https://reviews.llvm.org/D141865



More information about the llvm-commits mailing list