[PATCH] D138809: [RISCV] Support vector crypto extension LLVM IR

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2704
 
+multiclass VPseudoVALU_VCLMUL<string Constraint = ""> {
+  foreach m = MxList in {
----------------
This parameter is never used.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2712
+
+    defm _VV : VPseudoBinary<m.vrclass, m.vrclass, m.vrclass, m, Constraint>,
+               Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
----------------
I think this can use VPseudoBinaryV_VV


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2714
+               Sched<[WriteVIALUV_MX, ReadVIALUV_MX, ReadVIALUV_MX, ReadVMask]>;
+    defm _VX : VPseudoBinary<m.vrclass, m.vrclass, GPR, m, Constraint>,
+               Sched<[WriteVIALUX_MX, ReadVIALUV_MX, ReadVIALUX_MX, ReadVMask]>;
----------------
I think this can use VPseudoBinaryV_VX


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3555
 
+class PPatUnaryNoMask<string intrinsic_name,
+                      string inst,
----------------
I don't think using "PPat" instead of "VPat" meaningful highlights the difference between these patterns. The instructions being OP_P is an encoding detail only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138809/new/

https://reviews.llvm.org/D138809