[PATCH] D142047: [opt] Fix static code analysis concerns

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/tools/opt/NewPMDriver.cpp:370
       if (!P)
         errs() << "CSInstrUse needs to be together with InstrUse";
+      else
----------------
asudarsa wrote:
> aeubanks wrote:
> > we should instead `return false` anywhere we're printing an error message
> Thanks for the review. I have addressed it.
sorry, could you also update the two places above that print an error message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142047/new/

https://reviews.llvm.org/D142047