[PATCH] D142115: [ValueTracking] Take poison-generating metadata into account (PR59888)

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

LGTM, except for the align metadata.



================
Comment at: llvm/lib/IR/Instruction.cpp:217
+         hasMetadata(LLVMContext::MD_nonnull) ||
+         hasMetadata(LLVMContext::MD_align);
+}
----------------
not sure about align.
If a pointer is not sufficiently aligned, a load may crash. Returning poison in that case is not strong enough for the hardware behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142115/new/

https://reviews.llvm.org/D142115