[PATCH] D136524: [InstCombine] Handle select inst when eliminating constant memcpy

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 06:47:11 PST 2023


nikic added a comment.

In D136524#4065545 <https://reviews.llvm.org/D136524#4065545>, @gandhi21299 wrote:

> In D136524#4065295 <https://reviews.llvm.org/D136524#4065295>, @nikic wrote:
>
>> This is missing a test with different address space and removed alloca, but otherwise looks fine.
>
> Is there one? I can't think of a test case where the source and dest of a memcpy are in different address spaces and the alloca is removed.

A select between alloca and gep of alloca should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136524/new/

https://reviews.llvm.org/D136524



More information about the llvm-commits mailing list