[PATCH] D142099: 'on_line' parameter added to DexExpectStepOrder in the Dexter syntax

[Ben Mudd via Phabricator via llvm-commits]

BenJMudd added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py:22-23
 def have_hit_line(watch, loc):
-  if hasattr(watch, '_on_line'):
-    return watch._on_line == loc.lineno
+  if hasattr(watch, 'on_line'):
+    return watch.on_line == loc.lineno
   elif hasattr(watch, '_from_line'):
----------------
Orlando wrote:
> This change seems a little bit suspicious - as mentioned offline perhaps this was doing the wrong thing before though. It does certainly look like no command classes ever set `_on_line`, so it looks like this is doing the right thing with your patch.
> 
> Have you checked the llvm-lit tests in `cross-project-tests/debuginfo-tests/dexter/feature_tests`  pass (preferably on Linux as it has greater coverage)?
Yep, just tested those tests on Linux both before and after removing this _on_line check, no difference in the output, they all pass, so I think it must have been doing the wrong thing before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142099/new/

https://reviews.llvm.org/D142099