[PATCH] D141680: [GVN] Refactor findDominatingLoad function

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 06:06:06 PST 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1125
+      Instruction *Inst = &*I;
+      if (isModSet(AA->getModRefInfo(Inst, Loc)))
+        return nullptr;
----------------
It would be better to create a BatchAAResults instance before the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141680/new/

https://reviews.llvm.org/D141680



More information about the llvm-commits mailing list