[PATCH] D142009: GlobalISel: Split main function of RegBankSelect up

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.

LGTM



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/RegBankSelect.h:645
+  ///
+  /// FIXME: This should be in the MachineVerifier.
+  bool checkFunctionIsLegal(MachineFunction &MF) const;
----------------
+1 :D


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:726
+  }
+#endif
+
----------------
Nit: I would remove the `NDEBUG` guards here.

In this patch the caller is already doing that and longer term if other users appear, I would expect that they would want to actually check something (or wrap that in their own guards, e.g., assert).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142009/new/

https://reviews.llvm.org/D142009