[PATCH] D142102: [RISCV] Combine FP_TO_INT to vfwcvt/fvncvt

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:11651
+    // =========================================================================
+
   case RISCV::PseudoVFCVT_RM_X_F_V_M1_MASK:
----------------
This is growing really unwieldy as it needs to handle the matrix of `{X_F,XU_F,F_X,F_XU} x {M1,M2,M4,M8,MF2,MF4} x {vfcvt, vfwcvt, vfncvt}`. Could this tablegen'ed away in another patch?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:5579-5582
+let Uses = [FRM] in {
 defm PseudoVFWCVT_F_XU     : VPseudoVWCVTF_V;
 defm PseudoVFWCVT_F_X      : VPseudoVWCVTF_V;
+}
----------------
Added in the use here to match VFCVT


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:5610-5613
+let Uses = [FRM] in
+defm PseudoVFNCVT_F_F      : VPseudoVNCVTD_W;
+
+defm PseudoVFNCVT_ROD_F_F  : VPseudoVNCVTD_W;
----------------
Added in use to match VFCVT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142102/new/

https://reviews.llvm.org/D142102