[PATCH] D140666: [InstCombine] combine intersection for inequality icmps

Yingchi Long via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 01:28:05 PST 2023


inclyc updated this revision to Diff 490411.
inclyc added a comment.

Address comments

- merge NotMixed & Mixed
- add precommite revision
- use ConstT instead of "create and"
- bailout assertions

Todo:

- understandable comments
- robust tests (How can I test icmps that are expected failing?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140666/new/

https://reviews.llvm.org/D140666

Files:
  llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
  llvm/test/Transforms/InstCombine/icmp-logical.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140666.490411.patch
Type: text/x-patch
Size: 5457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230119/0da6e6e9/attachment.bin>


More information about the llvm-commits mailing list