[PATCH] D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 01:24:55 PST 2023


phosek added inline comments.


================
Comment at: llvm/include/llvm/Support/LLVMDriver.h:26-28
+  const char *GetProgName() const {
+    return NeedsPrependArg ? PrependArg : Path;
+  }
----------------
This only has one caller right now so I'd inline it.


================
Comment at: llvm/include/llvm/Support/LLVMDriver.h:30
+
+  bool IsLLVMDriver() const { return !!PrependArg; }
+};
----------------
This is unused so I'd just remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137800/new/

https://reviews.llvm.org/D137800



More information about the llvm-commits mailing list