[PATCH] D141277: [InstCombine] Don't optimize idempotent `atomicrmw <op>, 0` into `load atomic`

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 01:23:51 PST 2023


qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/atomicrmw.ll:5
 ; Check that we can replace `atomicrmw <op> LHS, 0` with `load atomic LHS`.
 ; This is possible when:
+; Check that we don't replace `atomicrmw <op> LHS, 0` with `load atomic LHS`.
----------------
qcolombet wrote:
> nikic wrote:
> > I think the two comment lines above were supposed to be dropped.
> Good catch, looks like I screwed up the merge conflict.
Fixed in ffafa0d43d81


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141277/new/

https://reviews.llvm.org/D141277



More information about the llvm-commits mailing list