[PATCH] D142084: [X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

Bing Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 00:49:57 PST 2023


yubing added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:79
   ManualMapEntry(const char *RegInstStr, const char *MemInstStr,
-                 UnfoldStrategy Strategy = NO_STRATEGY)
+                 uint16_t Strategy = NO_STRATEGY)
       : RegInstStr(RegInstStr), MemInstStr(MemInstStr), Strategy(Strategy) {}
----------------
craig.topper wrote:
> Where is NO_STRATEGY define? It looks like it was deleted from the left hand of this diff.
changed to 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084



More information about the llvm-commits mailing list