[PATCH] D142084: [X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:61
+  // (stored in bits 12 - 13)
+  TB_BCAST_TYPE_SHIFT = 12,
+  TB_BCAST_D    =   0 << TB_BCAST_TYPE_SHIFT,
----------------
Don't duplicate the definitions in llvm/lib/Target/X86/X86InstrFoldTables.h, try finding a common place


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:197
     void print(formatted_raw_ostream &OS) const {
+      // Stop printing record if it can't fold and unfold.
+      if(CannotUnfold && CannotFold)
----------------
See my comments in https://reviews.llvm.org/D142083, we can change thing to print here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084