[PATCH] D141777: [X86] Reenable store merging post-legalization

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:674-675
+        return TargetLoweringBase::StoreSource::Load;
       default:
-        return StoreSource::Unknown;
+        return TargetLoweringBase::StoreSource::Unknown;
       }
----------------
I'd agree with @barannikov88. `Unknown` and optional represent the same meaning. Why don't return `std::nullopt` here too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141777/new/

https://reviews.llvm.org/D141777