[PATCH] D142047: [opt] Fix static code analysis concerns
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 18 19:47:06 PST 2023
aeubanks added inline comments.
================
Comment at: llvm/tools/opt/NewPMDriver.cpp:370
if (!P)
errs() << "CSInstrUse needs to be together with InstrUse";
+ else
----------------
we should instead `return false` anywhere we're printing an error message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142047/new/
https://reviews.llvm.org/D142047
More information about the llvm-commits
mailing list