[PATCH] D141020: [X86][ABI] Don't preserve return regs for preserve_all/preserve_most CCs

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

Looks great!



================
Comment at: llvm/test/CodeGen/X86/preserve_allcc64.ll:9
 
-define preserve_allcc void @preserve_allcc1() nounwind {
+define preserve_allcc RETTYPE @preserve_allcc1() nounwind {
 entry:
----------------
I think it's better to put these 2 tests into a seperate file. It just waste time to run multi times on the other 2 tests.


================
Comment at: llvm/test/CodeGen/X86/preserve_allcc64.ll:11-23
+;ALL-LABEL:   preserve_allcc1
+;ALL:         pushq %r10
+;ALL-NEXT:    pushq %r9
+;ALL-NEXT:    pushq %r8
+;ALL-NEXT:    pushq %rdi
+;ALL-NEXT:    pushq %rsi
+;VOID-NEXT:   pushq %rdx
----------------
This will brings difficulties in future updates, though I think it's rare this file will be affected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141020/new/

https://reviews.llvm.org/D141020