[PATCH] D141740: [IRLinker] Replace CallInstr with CallBase

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 18:21:36 PST 2023


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with one test fix noted below. Thanks for the fix!



================
Comment at: llvm/test/Linker/drop-attribute.ll:14
+; Test that checks that nocallback attribute on a call-site in an invoke instruction is dropped.
+; CHECK-NEXT: invoke void @test_nocallback_call_site()
+define i32 @main() personality i8 0 {
----------------
I think you need to add the {{$}} at the end to make sure the nocallback attribute is gone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141740/new/

https://reviews.llvm.org/D141740



More information about the llvm-commits mailing list