[PATCH] D141740: [IRLinker] Replace CallInstr with CallBase

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 16:39:59 PST 2023


tejohnson added a comment.

In D141740#4063865 <https://reviews.llvm.org/D141740#4063865>, @gulfem wrote:

> In D141740#4053365 <https://reviews.llvm.org/D141740#4053365>, @arsenm wrote:
>
>> Needs test
>
> What kind of test would be good to add here?
> I had a test (`drop-attribute.ll`) in D137360 <https://reviews.llvm.org/D137360>, that checks the usage of `updateAttributes` functionality. Do you suggest extending that for `invoke` instruction?

I think you could just extend that test to include an invoke instruction and confirm it is handled correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141740/new/

https://reviews.llvm.org/D141740



More information about the llvm-commits mailing list