[PATCH] D139861: [llvm] boilerplate for new callbrprepare codegen IR pass

[Bill Wendling via Phabricator via llvm-commits]

void accepted this revision.
void added a comment.

A couple nits, but overall okay.



================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:719
+  //  Add both the safe stack and the stack protection passes: each of them will
+  //  only protect functions that have corresponding attributes.
   addPass(SafeStackPass());
----------------
nit: Probably don't need to reformat this comment.


================
Comment at: llvm/lib/CodeGen/CallBrPrepare.cpp:9
+//
+// This pass lowers callbrs in LLVM IR to something closer that the backend can
+// perform correct instruction selection for.  In particular, callbr may have
----------------
s/closer//


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139861/new/

https://reviews.llvm.org/D139861