[PATCH] D142061: [SPIR-V] Add -opaque-pointers=0 to some LIT tests

Michal Paszkowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 15:15:10 PST 2023


mpaszkowski created this revision.
mpaszkowski added reviewers: nikic, zuban32, konrad.trifunovic, iliya-diyachkov.
Herald added subscribers: StephenFan, wenlei, ThomasRaoux, Anastasia.
Herald added a project: All.
mpaszkowski requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

@nikic in D141912 <https://reviews.llvm.org/D141912> removed auto-detection of typed pointers and added `-opaque-pointers=0` to LITs which still require changes in other backends. Unfortunately, we still have such tests in the SPIR-V backend. This patch adds `-opaque-pointers=0` to the 50 LIT tests which still require changes. I will create a tracker issue on GitHub for those tests and convert as many as possible to opaque pointers starting next week. However, some will need to wait for Joshua's changes introducing target extension types for OpenCL.

@nikic Please accept the patch and keep us in the loop. I will include you in the upcoming patches.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142061

Files:
  llvm/test/CodeGen/SPIRV/EnqueueEmptyKernel.ll
  llvm/test/CodeGen/SPIRV/SampledImageRetType.ll
  llvm/test/CodeGen/SPIRV/atomicrmw.ll
  llvm/test/CodeGen/SPIRV/constant/global-constants.ll
  llvm/test/CodeGen/SPIRV/constant/local-null-constants.ll
  llvm/test/CodeGen/SPIRV/function/alloca-load-store.ll
  llvm/test/CodeGen/SPIRV/half_extension.ll
  llvm/test/CodeGen/SPIRV/half_no_extension.ll
  llvm/test/CodeGen/SPIRV/image-unoptimized.ll
  llvm/test/CodeGen/SPIRV/image.ll
  llvm/test/CodeGen/SPIRV/image_decl_func_arg.ll
  llvm/test/CodeGen/SPIRV/image_dim.ll
  llvm/test/CodeGen/SPIRV/image_store.ll
  llvm/test/CodeGen/SPIRV/link-attribute.ll
  llvm/test/CodeGen/SPIRV/linked-list.ll
  llvm/test/CodeGen/SPIRV/literal-struct.ll
  llvm/test/CodeGen/SPIRV/llvm-intrinsics/memset.ll
  llvm/test/CodeGen/SPIRV/llvm-intrinsics/sqrt.ll
  llvm/test/CodeGen/SPIRV/opencl.queue_t.ll
  llvm/test/CodeGen/SPIRV/opencl/basic/get_global_offset.ll
  llvm/test/CodeGen/SPIRV/opencl/basic/progvar_prog_scope_init.ll
  llvm/test/CodeGen/SPIRV/opencl/basic/vstore_private.ll
  llvm/test/CodeGen/SPIRV/opencl/image.ll
  llvm/test/CodeGen/SPIRV/pstruct.ll
  llvm/test/CodeGen/SPIRV/read_image.ll
  llvm/test/CodeGen/SPIRV/spirv.Queue.ll
  llvm/test/CodeGen/SPIRV/struct.ll
  llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpConstantSampler.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpImageQuerySize.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpImageReadMS.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpImageSampleExplicitLod.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpImageWrite.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpenCL/atomic_cmpxchg.ll
  llvm/test/CodeGen/SPIRV/transcoding/OpenCL/atomic_legacy.ll
  llvm/test/CodeGen/SPIRV/transcoding/SampledImage.ll
  llvm/test/CodeGen/SPIRV/transcoding/block_w_struct_return.ll
  llvm/test/CodeGen/SPIRV/transcoding/check_ro_qualifier.ll
  llvm/test/CodeGen/SPIRV/transcoding/cl-types.ll
  llvm/test/CodeGen/SPIRV/transcoding/clk_event_t.ll
  llvm/test/CodeGen/SPIRV/transcoding/enqueue_kernel.ll
  llvm/test/CodeGen/SPIRV/transcoding/extract_insert_value.ll
  llvm/test/CodeGen/SPIRV/transcoding/get_image_num_mip_levels.ll
  llvm/test/CodeGen/SPIRV/transcoding/global_block.ll
  llvm/test/CodeGen/SPIRV/transcoding/image_get_size_with_access_qualifiers.ll
  llvm/test/CodeGen/SPIRV/transcoding/image_with_access_qualifiers.ll
  llvm/test/CodeGen/SPIRV/transcoding/optional-core-features-multiple.ll
  llvm/test/CodeGen/SPIRV/transcoding/spec_const.ll
  llvm/test/CodeGen/SPIRV/transcoding/spirv-private-array-initialization.ll
  llvm/test/CodeGen/SPIRV/transcoding/spirv-types.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142061.490312.patch
Type: text/x-patch
Size: 28303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230118/98e6e476/attachment.bin>


More information about the llvm-commits mailing list