[PATCH] D111456: [InlineCost] model calls to llvm.objectsize.*

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added a comment.

Bumping for review; this is actively hurting our ability to protect C code with FORTIFY_SOURCE.

The proposed changes sound nice, seem like pretty significant reworking of inline cost modeling that itself sounds significantly riskier than this patch.  I'll leave reworking inline cost model in such a way to others to burden such refactoring risk.

IMO it's a major deficit at the moment of inline cost modeling not knowing about most LLVM intrinsics, and penalizing callers for the full cost of a function call at runtime when many intrinsics don't result in any code being generated at all.  This is a simple patch towards improving that problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111456/new/

https://reviews.llvm.org/D111456