[PATCH] D141989: [InstSimplify] Add tests for ctpop(X) where X is a power of 2; NFC

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 10:40:07 PST 2023


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D141989#4062664 <https://reviews.llvm.org/D141989#4062664>, @goldstein.w.n wrote:

> In D141989#4061879 <https://reviews.llvm.org/D141989#4061879>, @spatel wrote:
>
>> Add/change one of these tests to a vector type, so we have some coverage for that possibility.
>
> Done.
>
>> And as noted in the other review, this set of tests (and transform) can go into the InstSimplify directory because we are not creating any new instructions.
>
> Any idea which file. Grepping around I didn't see any obvious places this belongs.

llvm/test/Transforms/InstSimplify/call.ll checks a grab-bag of assorted intrinsics, but there's enough here to warrant a new file.
LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141989/new/

https://reviews.llvm.org/D141989



More information about the llvm-commits mailing list