[PATCH] D141712: [GVN] Improve PRE on load instructions

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added a comment.

In D141712#4062475 <https://reviews.llvm.org/D141712#4062475>, @kachkov98 wrote:

> In general, I'm concerned that this patch tries to combine 2 different transformations: load PRE and hoisting. It can omit critical edge splitting in some cases, but after hoisting we can also cleanup CFG.

Sort of. But most of the code are used to detect the optimization opportunities, some changes to reuse current code to insert load into PredBB, only the changes in eliminatePartiallyRedundantLoad are specifically for the hoisting part. I think it's a too heavy hammer for this purpose, especially the expected following pass is still unavailable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712