[PATCH] D141387: [DebugInfo] Store instr-ref/DBG_VALUE mode of a MachineFunction in a member variable

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 07:45:14 PST 2023


Orlando added a comment.

Still LGTM



================
Comment at: llvm/test/DebugInfo/MIR/X86/live-debug-values-bad-transfer.mir:10
+# An identical test in llvm/test/DebugInfo/MIR/X86/live-debug-values-bad-transfer2.mir
+# checks this for VarLocBasedLDV
 #
----------------
smallest of nits: missing full stop (only mentioning as it's inconsistent with the other changes!).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141387/new/

https://reviews.llvm.org/D141387



More information about the llvm-commits mailing list