[PATCH] D142020: AMDGPU: Partially fix machine uniformity for inline asm

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 07:18:53 PST 2023


arsenm created this revision.
arsenm added reviewers: sameerds, Pierre-vh, Petar.Avramovic, AMDGPU, aemerson, paquette, foad, nhaehnle.
Herald added subscribers: kosarev, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was assuming virtual registers only, and asserting on physical.
This was also ignoring AGPRs, and only considering VGPRs.

      

Reporting the instruction as uniform or not is conceptually wrong,
this should be reported per-operand. An inline asm statement could
include uniform and non-uniform components. This should report
purely for the register defs and ignore the uses.

      

Fixes asserting on most of the inline asm tests when uniformity
analysis is used.


https://reviews.llvm.org/D142020

Files:
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/lib/CodeGen/RegisterBankInfo.cpp
  llvm/lib/Target/AMDGPU/GCNSubtarget.h
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142020.490149.patch
Type: text/x-patch
Size: 7539 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230118/782a203e/attachment.bin>


More information about the llvm-commits mailing list