[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 18 06:29:59 PST 2023
lebedev.ri added a comment.
Ok, so. I looked really hard, and essentially i'm not sure we can just change those attributes from implying `readonly`/`readnone`.
Things kinda just fall apart
================
Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20
// Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute.
+// FIXME: we don't, though.
// CHECK-LABEL: @test_const_attr
----------------
I've looked, and i really don't understand how D64319 works.
It seems like the AST is then serialized into a header?
Because just adding a new attribute without spelling does not solve the issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138958/new/
https://reviews.llvm.org/D138958
More information about the llvm-commits
mailing list