[PATCH] D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 02:40:08 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:707
+      if (!IgnoreUnknown && Name.size() == Type.size()) {
+        if (IgnoreUnknown)
+          continue;
----------------
This is dead code.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:727
+      if (!IgnoreUnknown && llvm::is_contained(AllExts, Name)) {
+        if (IgnoreUnknown)
+          continue;
----------------
This is dead code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139553/new/

https://reviews.llvm.org/D139553



More information about the llvm-commits mailing list