[llvm] 4756f9a - [LLVMContext] Remove hasSetOpaquePointersValue() API (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 02:14:34 PST 2023


Author: Nikita Popov
Date: 2023-01-18T11:14:26+01:00
New Revision: 4756f9ae0aa6c2a0b4231d93d5166c055f303603

URL: https://github.com/llvm/llvm-project/commit/4756f9ae0aa6c2a0b4231d93d5166c055f303603
DIFF: https://github.com/llvm/llvm-project/commit/4756f9ae0aa6c2a0b4231d93d5166c055f303603.diff

LOG: [LLVMContext] Remove hasSetOpaquePointersValue() API (NFC)

Now that we no longer perform any kind of typed pointer guessing,
we no longer need this API.

Added: 
    

Modified: 
    llvm/include/llvm/IR/LLVMContext.h
    llvm/lib/IR/LLVMContext.cpp
    llvm/lib/IR/LLVMContextImpl.cpp
    llvm/lib/IR/LLVMContextImpl.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/IR/LLVMContext.h b/llvm/include/llvm/IR/LLVMContext.h
index c380ed215b6cc..a8095a5c2fd30 100644
--- a/llvm/include/llvm/IR/LLVMContext.h
+++ b/llvm/include/llvm/IR/LLVMContext.h
@@ -311,9 +311,6 @@ class LLVMContext {
   /// LLVMContext is used by compilation.
   void setOptPassGate(OptPassGate&);
 
-  /// Whether we've decided on using opaque pointers or typed pointers yet.
-  bool hasSetOpaquePointersValue() const;
-
   /// Set whether opaque pointers are enabled. The method may be called multiple
   /// times, but only with the same value. Note that creating a pointer type or
   /// otherwise querying the opaque pointer mode performs an implicit set to

diff  --git a/llvm/lib/IR/LLVMContext.cpp b/llvm/lib/IR/LLVMContext.cpp
index 2b5577595ee3d..7911705776e33 100644
--- a/llvm/lib/IR/LLVMContext.cpp
+++ b/llvm/lib/IR/LLVMContext.cpp
@@ -368,10 +368,6 @@ std::unique_ptr<DiagnosticHandler> LLVMContext::getDiagnosticHandler() {
   return std::move(pImpl->DiagHandler);
 }
 
-bool LLVMContext::hasSetOpaquePointersValue() const {
-  return pImpl->hasOpaquePointersValue();
-}
-
 void LLVMContext::setOpaquePointers(bool Enable) const {
   pImpl->setOpaquePointers(Enable);
 }

diff  --git a/llvm/lib/IR/LLVMContextImpl.cpp b/llvm/lib/IR/LLVMContextImpl.cpp
index cd46a04a684b0..9acb1f654899f 100644
--- a/llvm/lib/IR/LLVMContextImpl.cpp
+++ b/llvm/lib/IR/LLVMContextImpl.cpp
@@ -249,10 +249,6 @@ void LLVMContextImpl::setOptPassGate(OptPassGate& OPG) {
   this->OPG = &OPG;
 }
 
-bool LLVMContextImpl::hasOpaquePointersValue() {
-  return OpaquePointers.has_value();
-}
-
 bool LLVMContextImpl::getOpaquePointers() {
   if (LLVM_UNLIKELY(!OpaquePointers))
     OpaquePointers = OpaquePointersCL;

diff  --git a/llvm/lib/IR/LLVMContextImpl.h b/llvm/lib/IR/LLVMContextImpl.h
index e5d9b39261ed0..d2651a6ec72e2 100644
--- a/llvm/lib/IR/LLVMContextImpl.h
+++ b/llvm/lib/IR/LLVMContextImpl.h
@@ -1627,7 +1627,6 @@ class LLVMContextImpl {
   // TODO: clean up the following after we no longer support non-opaque pointer
   // types.
   bool getOpaquePointers();
-  bool hasOpaquePointersValue();
   void setOpaquePointers(bool OP);
 
 private:


        


More information about the llvm-commits mailing list