[PATCH] D139553: [llvm-objdump][RISCV] Use new common method to parse ARCH RISCV attribute

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2014
+  if (!FeaturesValue)
+    WithColor::error(errs(), ToolName) << FeaturesValue.takeError();
+  SubtargetFeatures Features = *FeaturesValue;
----------------
How does this work? Don't we need to somehow exit after reporting the error? Is there a test for this path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139553/new/

https://reviews.llvm.org/D139553