[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added a comment.

In D141899#4061237 <https://reviews.llvm.org/D141899#4061237>, @zixuan-wu wrote:

> With considering https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility I think we need make consensus to choose one option from following 2 options.
>
> 1. Remove X86amx type in IR totally. (what I am doing now)
> 2. Without removing X86amx type in IR, just upgrade the x86amx type to target extension and also upgrade bitcast llvm instruction to intrinsic(required). It also includes changing the testcase to target extension type.
>
> BTW, need we make consensus about whether to do this purify patch anymore?

For option 2 is it possible to make x86_amx and target extension type co-exist and have a knob to control it? The new feature can base on the target extension type, and if the target extension type is validated on more and more applications we need figure out a way to deprecate the old type someday.

I don't think we need to puirfy the patch anymore. I prefer to have 2 type co-exist for some time and deprecate 1 in a proper and safe way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141899/new/

https://reviews.llvm.org/D141899