[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

Tue Jan 17 17:48:53 PST 2023

joshua-arch1 added a comment.

In D140460#4059422 <https://reviews.llvm.org/D140460#4059422>, @craig.topper wrote:

> In D140460#4055333 <https://reviews.llvm.org/D140460#4055333>, @joshua-arch1 wrote:
>
>> In D140460#4050322 <https://reviews.llvm.org/D140460#4050322>, @craig.topper wrote:
>>
>>> I think according to the spec, we need to support parsing "Minimum positive normal" in decimal form. The exact value for is different for fli.h, fli.s, and fli.d.
>>
>> I think there will be some difficulties in expressing 'minimum positive normal' in decimal form. For single-presicion minimum positive normal, the value is 1.1754943508222875079687365372222456778186655567720875215087517062784172594547271728515625E-38.  For double-precison, the value will need to be expressed in a much larger precision even if we use toString().
>
> The disassembler should print "min", but the parser should accept the full value.

In my implementation, the parser can already accept the full value of 'min' as long as we give the immediate with the exact precision.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460