[PATCH] D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)"

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 16:50:25 PST 2023


eugenis created this revision.
eugenis added reviewers: danielkiss, pbarrio.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
eugenis requested review of this revision.
Herald added a project: LLVM.

Linux kernel sets SCTRL_EL1.BT0 and BT1 to 1 unconditionally, which
makes PACIASP equivalent to BTI C + PACIA LR,SP.

Use the shorter instruction sequence by default.

I'm not aware of anyone who needs the opposite. They are welcome to
revert to the current behavior under a subtarget feature or an
environment check.

This reverts commit 571c8c5263a79293aaadae07b11feb36726eaf53 <https://reviews.llvm.org/rG571c8c5263a79293aaadae07b11feb36726eaf53>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141978

Files:
  llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/test/CodeGen/AArch64/aarch64-signedreturnaddress.ll
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-sp-mod.ll
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-subtarget.ll
  llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-v8-3.ll
  llvm/test/CodeGen/AArch64/pacbti-llvm-generated-funcs-2.ll
  llvm/test/CodeGen/AArch64/pacbti-module-attrs.ll
  llvm/test/CodeGen/AArch64/sign-return-address-cfi-negate-ra-state.ll
  llvm/test/CodeGen/AArch64/sign-return-address.ll
  llvm/test/CodeGen/AArch64/wineh-pac.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141978.489984.patch
Type: text/x-patch
Size: 18707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230118/655f35b0/attachment.bin>


More information about the llvm-commits mailing list