[PATCH] D135915: [ConstraintElim] Enable pass by default.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D135915#4060227 <https://reviews.llvm.org/D135915#4060227>, @asbirlea wrote:

> Reverting should be acceptable here.
> AFAIU, the norm for work with high impact (adding a pass to the pipeline is one) is to do the work itself under a flag so the work itself does not get reverted if there are issues, and for the flag flip patch (such as this one) to be reverted if issues arise. 
> When the issue is resolved, the flag flip patch should be re-landed.
> Regressing a test by ~1000%, seems like a solid reason to revert if a solution is not immediately available, especially with having a reproducer available that confirms the issue.

Agreed, I had an initial look and I don't think there will be an immediate fix. I'll revert the commit early tomorrow morning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135915/new/

https://reviews.llvm.org/D135915