[PATCH] D141337: [SPIR-V] Fix translation of aggregate undef operands

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added a comment.

Checking (by spirv-val) the backend's binary output for undef-composite-store.ll test shows this issue:

  error: line 25: OpStore Pointer <id> '2[%ptr]'s type does not match Object <id> '13[%13]'s type.
    OpStore %ptr %13 Aligned 4

I would also suggest not changing the current Undef output format (implied in the two changed tests), but generating the output closer to the translator's one (despite the fact that the implemented solution looks standard-compliant). I suppose this may be implemented by introducing a new spv_undef intrinsic (similar to spv_alloca).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141337/new/

https://reviews.llvm.org/D141337