[PATCH] D141315: Verifier: Add checks for associated metadata

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM with a comment



================
Comment at: llvm/lib/IR/Verifier.cpp:664
+      const auto *VM = dyn_cast_or_null<ValueAsMetadata>(Op);
+      Check(VM, "associated metadata must be ValueAsMetadata", GO, Associated);
+      if (VM) {
----------------
It looks like the `!{null}` case will print both "must have a global value" and "must be ValueAsMetadata". We probably want just the first one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141315/new/

https://reviews.llvm.org/D141315