[PATCH] D141877: [NFC][X86] `canonicalizeShuffleWithBinOps()`: refactor and generalize, NFC

Tue Jan 17 13:43:55 PST 2023

lebedev.ri added a comment.

In D141877#4060254 <https://reviews.llvm.org/D141877#4060254>, @RKSimon wrote:

> In D141877#4059374 <https://reviews.llvm.org/D141877#4059374>, @lebedev.ri wrote:
>
>> @RKSimon if you prefer, you may write these changes by yourself. I can abandon these patches.
>
> If you can wait a couple of days - I'm happy to get this done.

I just don't understand why would anyone write this any other way.
Manual loop unrolling results in more code, and worse code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141877/new/

https://reviews.llvm.org/D141877