[PATCH] D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 11:12:35 PST 2023


yln added a comment.

Thanks so much for this effort and seeing it through!  I think this materially improves LIT feature handling and reduces confusion.

I had just one question: what kind of testing did we do / how did we discover all uses of the triple substring matches?
To reduce churn and the probability that this gets reverted, can we add a short explanation to the commit message that explains how patterns like `UNSUPPORTED: arm64` should be changed and maybe a link to the commit that did this for an existing example.

Thanks so much again!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141007/new/

https://reviews.llvm.org/D141007



More information about the llvm-commits mailing list