[PATCH] D141651: [OMPIRBuilder] Pass dependencies to createTask by value

Tue Jan 17 10:54:15 PST 2023

psoni2628 added a comment.

In D141651#4058516 <https://reviews.llvm.org/D141651#4058516>, @kiranchandramohan wrote:

> Assuming this was not triggered because we never used `Dependencies` vector before and no other `PostOutlineCB` took an option (with a reference) like this.

Yes that's right. There is no other `PostOutlineCB` that has a `SmallVector` being passed as an `ArrayRef`.

In D141651#4059097 <https://reviews.llvm.org/D141651#4059097>, @shraiysh wrote:

> Please add a test case which would fail with the old implementation but passes with the new one.

I have adjusted the existing test case slightly to fail with the old implementation. There isn't really any point of keeping the old test case around because it is unrealistic. The original stack-allocated `DependData` should not be expected to still be in scope when the `PostOutlineCB` lambda is called.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141651/new/

https://reviews.llvm.org/D141651