[PATCH] D141924: [IR] Add new intrinsics interleave and deinterleave vectors

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:11605
+  if (!OutVT.isScalableVector()) {
+    SmallVector<int, 8> Mask;
+    unsigned NumElts = InVT.getVectorMinNumElements();
----------------
reames wrote:
> createInterleaveMask - though, I think you chose a different strategy using the concat_vector here.  Make sure you keep it consistent if you change one part.
ignore me on the second part of the comment here; I'd misread.

Reusing createInterleaveMask would still be good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141924/new/

https://reviews.llvm.org/D141924