[PATCH] D141877: [NFC][X86] `canonicalizeShuffleWithBinOps()`: refactor and generalize, NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 08:43:55 PST 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:40498
+        std::array<SDValue, 2> N0Ops;
+        for (auto I : zip(N0->ops(), N0Ops))
+          std::get<1>(I) = peekThroughOneUseBitcasts(std::get<0>(I));
----------------
Given we know that N0 is a binop - all this generic zip/enumate iteration code seems unnecessary tbh.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141877/new/

https://reviews.llvm.org/D141877



More information about the llvm-commits mailing list