[PATCH] D141679: [CodeGen][Dwarf] Generate global variable DIEs after all subprogram (and their abstract origin) DIEs

Tue Jan 17 08:30:03 PST 2023

dblaikie added a comment.

In D141679#4056029 <https://reviews.llvm.org/D141679#4056029>, @jmmartinez wrote:

> In D141679#4052278 <https://reviews.llvm.org/D141679#4052278>, @dblaikie wrote:
>
>> This might have some overlap with all the work to scope non-instanced local entities (local statics and local types) that were reverted in 62a6b9e9ab3eb778111e90a34fee1e6a7c64db8a <https://reviews.llvm.org/rG62a6b9e9ab3eb778111e90a34fee1e6a7c64db8a> ?
>>
>> Could we move the variable construction in one patch, then fix the functionality in a separate patch? will make it easier to review the mechanical changes separately from the semantic ones.
>
> Thanks for pointing me to that patch. I took a quick look and it seems that the patch in https://reviews.llvm.org/D125693 does a much better job at addressing the issue.
>
> I'm closing this patch.

I will note that that patch series has stalled out - so if you're interested in this functionality, perhaps you'd be interested in trying to resurrect (either by getting the interest of the previous contributors, or commandeering the work/taking it on yourself) it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141679/new/

https://reviews.llvm.org/D141679