[PATCH] D141895: [AMDGPU] Add missing physical register check in SIFoldOperands::tryFoldLoad

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Could also use mir test



================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a -O3 < %s
+ at a0000000000000000000000000000000004040 = external protected addrspace(4) externally_initialized global [4096 x i64], align 16
----------------
Don’t need -O3 and does need checks 


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:7
+entry:
+  switch i32 undef, label %sw.epilog [
+    i32 3, label %sw.bb8
----------------
Avoid branch on undef 


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:30
+attributes #0 = { noinline }
+attributes #1 = { "target-features"="+16-bit-insts,+add-no-carry-insts,+aperture-regs,+atomic-fadd-no-rtn-insts,+atomic-fadd-rtn-insts,+atomic-pk-fadd-no-rtn-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dot7-insts,+dpp,+dpp-64bit,+enable-ds128,+enable-prt-strict-null,+fast-denormal-f32,+fast-fmaf,+flat-address-space,+flat-for-global,+flat-global-insts,+flat-inst-offsets,+flat-scratch-insts,+fma-mix-insts,+fp64,+full-rate-64-ops,+gcn3-encoding,+gfx7-gfx8-gfx9-insts,+gfx8-insts,+gfx9,+gfx9-insts,+gfx90a-insts,+image-insts,+int-clamp-insts,+inv-2pi-inline-imm,+ldsbankcount32,+load-store-opt,+localmemorysize65536,+mad-mac-f32-insts,+mai-insts,+negative-scratch-offset-bug,+packed-fp32-ops,+packed-tid,+pk-fmac-f16-inst,+promote-alloca,+r128-a16,+s-memrealtime,+s-memtime-inst,+scalar-atomics,+scalar-flat-scratch-insts,+scalar-stores,+sdwa,+sdwa-omod,+sdwa-scalar,+sdwa-sdst,+sramecc-support,+trap-handler,+unaligned-access-mode,+unaligned-buffer-access,+unaligned-ds-access,+vgpr-index-mode,+vop3p,-wavefrontsize16,-wavefrontsize32,+wavefrontsize64,+xnack-support" }
+attributes #2 = { convergent nounwind }
----------------
Can drop attributes and metadata 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141895/new/

https://reviews.llvm.org/D141895