[PATCH] D141883: [DAG] Do not combine any_ext when we combine and into zext.

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 06:41:20 PST 2023


deadalnix added inline comments.


================
Comment at: llvm/test/CodeGen/X86/illegal-bitfield-loadstore.ll:120
 ; X64-NEXT:    orl $384, (%rdi) # imm = 0x180
 ; X64-NEXT:    retq
   %aa = load i56, ptr %a, align 1
----------------
Yes, it also shows up in some regression in D127115


================
Comment at: llvm/test/CodeGen/X86/known-signbits-vector.ll:684
+; X64-NEXT:    negq %rax
 ; X64-NEXT:    retq
   %3 = fcmp oeq double %0, %1
----------------
Another optimization is defeated. D141884 generalize it so it kicks in again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141883/new/

https://reviews.llvm.org/D141883



More information about the llvm-commits mailing list