[PATCH] D141883: [DAG] Do not combine any_ext when we combine and into zext.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Seems like an improvement.



================
Comment at: llvm/test/CodeGen/X86/illegal-bitfield-loadstore.ll:115-120
 ; X64-LABEL: i56_or:
 ; X64:       # %bb.0:
-; X64-NEXT:    movzbl 6(%rdi), %eax
-; X64-NEXT:    shll $16, %eax
-; X64-NEXT:    movzwl 4(%rdi), %ecx
-; X64-NEXT:    movw %cx, 4(%rdi)
-; X64-NEXT:    shrq $16, %rax
-; X64-NEXT:    movb %al, 6(%rdi)
+; X64-NEXT:    movzwl 4(%rdi), %eax
+; X64-NEXT:    movw %ax, 4(%rdi)
 ; X64-NEXT:    orl $384, (%rdi) # imm = 0x180
 ; X64-NEXT:    retq
----------------
I'm guessing this is the improvement?


================
Comment at: llvm/test/CodeGen/X86/known-signbits-vector.ll:678-684
 ; X64-LABEL: signbits_cmpsd:
 ; X64:       # %bb.0:
 ; X64-NEXT:    vcmpeqsd %xmm1, %xmm0, %xmm0
 ; X64-NEXT:    vmovq %xmm0, %rax
+; X64-NEXT:    andl $1, %eax
+; X64-NEXT:    negq %rax
 ; X64-NEXT:    retq
----------------
What happens here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141883/new/

https://reviews.llvm.org/D141883