[PATCH] D141850: [SCEV] Preserve divisibility and min/max information in applyLoopGuards

Tue Jan 17 05:57:48 PST 2023

alonkom added a comment.

In D141850#4057996 <https://reviews.llvm.org/D141850#4057996>, @caojoshua wrote:

> What is the relation to https://reviews.llvm.org/D128701? Seems maybe you should close the other one.
>
> Can you make the commit title more specific, and add more info in the commit message? In particular, I would like to see something like:
>
>   after applyLoopGuards, turns <A> into <B>
>
> where A and B are SCEV expressions.
>
> Other information like, what the problem was before, and how you address it, is also helpful. I would suggest looking at the git log of ScalarEvolution.cpp for examples of descriptive commit messages. This will save the reviewers time, and will be helpful when people look at the git log/blame.

Thanks, updated the commit message.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141850/new/

https://reviews.llvm.org/D141850