[PATCH] D141471: [AArch64][SVE] Fix crash for DestructiveBinaryComm zero merging

Tue Jan 17 03:31:01 PST 2023

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

This is what I was referring to during my review of D124325 <https://reviews.llvm.org/D124325> whereby I was suggesting your fix was more generic than you thought and could be the way to solve all such problems for all the destructive types that have two or more operands.

That being said, I have no problem with build it up one destructive type at a time.

================
Comment at: llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:561
     // prefixed_zeroing_mov for DestructiveBinary.
-    assert((DOPRegIsUnique || AArch64::DestructiveBinary == DType) &&
+    assert((DOPRegIsUnique || (AArch64::DestructiveBinary == DType ||
+                               AArch64::DestructiveBinaryComm == DType)) &&
----------------
This being an || chain already in brackets I doubt you need these inner brackets.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141471/new/

https://reviews.llvm.org/D141471