[llvm] d279602 - [Linker] Convert test to opaque pointers (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 03:22:09 PST 2023


Author: Nikita Popov
Date: 2023-01-17T12:22:01+01:00
New Revision: d279602ba9a68943e6f138653e6ef5680d2095e1

URL: https://github.com/llvm/llvm-project/commit/d279602ba9a68943e6f138653e6ef5680d2095e1
DIFF: https://github.com/llvm/llvm-project/commit/d279602ba9a68943e6f138653e6ef5680d2095e1.diff

LOG: [Linker] Convert test to opaque pointers (NFC)

Removing pointer indirections to at least somewhat preserve test
intent. I wasn't aware this kind of directly co-recursive type
is even legal.

Added: 
    

Modified: 
    llvm/test/Linker/Inputs/pr22807-1.ll
    llvm/test/Linker/Inputs/pr22807-2.ll
    llvm/test/Linker/pr22807.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Linker/Inputs/pr22807-1.ll b/llvm/test/Linker/Inputs/pr22807-1.ll
index 4081a9b00e43..a1006bf409a1 100644
--- a/llvm/test/Linker/Inputs/pr22807-1.ll
+++ b/llvm/test/Linker/Inputs/pr22807-1.ll
@@ -1,4 +1,4 @@
-%struct.A = type { %struct.B* }
+%struct.A = type { %struct.B }
 %struct.B = type opaque
 
 define i32 @foo(%struct.A** %A) {

diff  --git a/llvm/test/Linker/Inputs/pr22807-2.ll b/llvm/test/Linker/Inputs/pr22807-2.ll
index 7739b77df255..137638e2987a 100644
--- a/llvm/test/Linker/Inputs/pr22807-2.ll
+++ b/llvm/test/Linker/Inputs/pr22807-2.ll
@@ -1,6 +1,6 @@
-%struct.A = type { %struct.B* }
+%struct.A = type { %struct.B }
 %struct.B = type opaque
 
-define i32 @bar(%struct.A* %A) {
+define i32 @bar(%struct.A %A) {
    ret i32 0
 }

diff  --git a/llvm/test/Linker/pr22807.ll b/llvm/test/Linker/pr22807.ll
index bb4ca2b4ccfb..1db1eabd0555 100644
--- a/llvm/test/Linker/pr22807.ll
+++ b/llvm/test/Linker/pr22807.ll
@@ -1,13 +1,13 @@
 ; RUN: llvm-link -S -o - %p/pr22807.ll %p/Inputs/pr22807-1.ll %p/Inputs/pr22807-2.ll | FileCheck %s
 
 ; CHECK-NOT: type
-; CHECK: %struct.B = type { %struct.A* }
-; CHECK-NEXT: %struct.A = type { %struct.B* }
+; CHECK: %struct.B = type { %struct.A }
+; CHECK-NEXT: %struct.A = type { %struct.B }
 ; CHECK-NOT: type
 
-%struct.B = type { %struct.A* }
+%struct.B = type { %struct.A }
 %struct.A = type opaque
 
-define i32 @baz(%struct.B* %BB) {
+define i32 @baz(%struct.B %BB) {
   ret i32 0
 }


        


More information about the llvm-commits mailing list